Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme section on PHPCompatibility #669

Merged
merged 1 commit into from
Aug 26, 2016
Merged

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Aug 25, 2016

Add some additional relevant information about running the PHPCompatibility sniffs.

Whichever way you run it, do make sure you set the `testVersion` to run the sniffs against. The `testVersion` determines for which PHP versions you will received compatibility information. The recommended setting for this at this moment is `5.2-7.1` to support the same PHP versions as WordPress Core supports.

For more information about setting the `testVersion`, see:
[PHPCompatibility: Using the compatibility sniffs](https://github.com/wimg/PHPCompatibility#using-the-compatibility-sniffs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use bullets here, or otherwise ensure this breaks on to a new line in the rendered view, as presumably intended in the markdown view.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Fixed.

@jrfnl jrfnl force-pushed the feature/update-readme branch from e9d1b5e to 43d6949 Compare August 25, 2016 14:39
@GaryJones GaryJones merged commit 94b4858 into develop Aug 26, 2016
@GaryJones GaryJones deleted the feature/update-readme branch August 26, 2016 07:55
@jrfnl jrfnl added this to the 0.10.0 milestone Aug 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants